gl renderer: Set an error if we don't have one already
authorTimm Bäder <mail@baedert.org>
Wed, 16 Sep 2020 03:57:11 +0000 (05:57 +0200)
committerTimm Bäder <mail@baedert.org>
Fri, 18 Sep 2020 13:39:07 +0000 (15:39 +0200)
We can't fail and not set the error, since caller don't expect that.

gsk/gl/gskglrenderer.c

index 2af766c99b4c37fc8160308203cb6d1afbc29a04..00fb5aea5ecee2a411598c62b937ba9b1dcb236d 100644 (file)
@@ -3035,6 +3035,10 @@ gsk_gl_renderer_create_programs (GskGLRenderer  *self,
 out:
   gsk_gl_shader_builder_finish (&shader_builder);
 
+  if (error && !(*error))
+    g_set_error (error, GDK_GL_ERROR, GDK_GL_ERROR_COMPILATION_FAILED,
+                 "Failed to compile all shader programs"); /* Probably, eh. */
+
   return programs;
 }